Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix nightly build of 1.4.x #14556

Merged
merged 4 commits into from
Apr 10, 2019
Merged

Fix nightly build of 1.4.x #14556

merged 4 commits into from
Apr 10, 2019

Conversation

Ishitori
Copy link
Contributor

Description

Nightly build of 1.4.x keeps failing - http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/NightlyTestsForBinaries/detail/v1.4.x/114/pipeline/

In 1.5.0 there is a major rewrite of this tutorial, but since 1.4.0 is already published, I made the smallest change possible to fix the failing build.

I checked the build after this change on my EC2 instance - all good.

Nightly build of 1.4.x keeps failing, and while in 1.5.0 there was a major rewrite for this tutorial, since 1.4.0 is already published, I made the smallest change possible to fix that. I checked the build after this change on my EC2 instance - all good.
@Ishitori Ishitori requested a review from szha as a code owner March 28, 2019 23:57
@abhinavs95
Copy link
Contributor

Thank you for the fix @Ishitori Could you have a look at the CI failures?

@mxnet-label-bot add [Build, pr-awaiting-review]

@marcoabreu marcoabreu added Build pr-awaiting-review PR is waiting for code review labels Mar 29, 2019
@piyushghai
Copy link
Contributor

@Ishitori The CI still seems to fail. :/
I've noticed it failed on another PR on v1.4.x branch as well : #14586

@Ishitori
Copy link
Contributor Author

Ishitori commented Apr 6, 2019

@piyushghai, it does fail, and it seems there is something wrong with TensorRT. We are trying to find someone experienced with TensorRT to figure it out.

@ThomasDelteil ThomasDelteil merged commit 8b68640 into apache:v1.4.x Apr 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Build pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants